Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Portals Bump Attacking Vehicles #16724

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Runian
Copy link
Contributor

@Runian Runian commented Nov 2, 2024

About The Pull Request

Trying to enter a linked portal while a vehicle is on the other side will cause nothing to happen.

Why It's Good For The Game

Icy said it was an exploit.

Changelog

🆑
fix: Moving into a linked portal while there is a vehicle on the other side will no longer cause a bump attack.
/:cl:

@tgstation-server tgstation-server added the Fix Fixes an issue with the game. label Nov 2, 2024
@Runian Runian marked this pull request as ready for review November 2, 2024 20:33
Copy link
Contributor

@Lumipharon Lumipharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should xenos be able to bump ANYTHING dense through a portal? seems extremely gross, and there's a variety of situations where it could happen, not just tanks.

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Pull request is awaiting delayed author response and may be closed. label Nov 11, 2024
@TiviPlus TiviPlus removed the Stale Pull request is awaiting delayed author response and may be closed. label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fixes an issue with the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants